fix(scoring): wire duplicate risk preview input - #512
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
gittensory-ui | c216c1b | Commit Preview URL Branch Preview URL |
Jun 10 2026, 08:28 AM |
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Note Gittensory Gate skippedPR closed before full evaluation. No late first comment was created.
Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers. |
This was referenced Jun 10, 2026
JSONbored
force-pushed
the
codex/fix-unreachable-duplicate_risk-blocker
branch
from
June 10, 2026 08:26
0a8c742 to
c216c1b
Compare
Closed
12 tasks
This was referenced Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
duplicate_riskreducer blocker inbuildScorePreview()depended onScorePreviewInput.duplicateRiskCount, but public API, MCP tool shapes, and some production call paths did not preserve or populate that field so the blocker was effectively unreachable in normal flows.Description
duplicateRiskCountto the public scoring preview Zod schema insrc/api/routes.tsso/v1/scoring/previewpreserves the signal intobuildScorePreview().duplicateRiskCountto the MCPscorePreviewShapeinsrc/mcp/server.tsso MCP tool calls (e.g.gittensory_preview_local_pr_score) and variant comparisons can provide the signal.test/integration/api.test.tsto verify the API and MCP tool retainduplicateRiskCountand that the resulting preview includes theduplicate_riskreducer blocker.duplicateRiskCountfrom preflight collisions, so the change only exposes the value to API/MCP callers and test coverage.Testing
npm test -- --run test/integration/api.test.ts test/unit/local-branch.test.ts test/unit/scenario-blockers.test.tsand all tests passed (Test Files 3 passed (3),Tests 80 passed (80)).npm run typecheck(tsc --noEmit) and it completed successfully.Codex Task